-
Notifications
You must be signed in to change notification settings - Fork 4
feat(decode): runtime support for structures #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cf9be46 to
d037d60
Compare
|
@jberthold I failed to pass Yes, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a make target update-smir-json which you could use. You just have to create an empty my/new/file.smir.json file first and then run make update-smir-json TARGETS=my/new/file.smir.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Could I keep this file or just delete it?
62e85e0 to
135ca3d
Compare
jberthold
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now, and the examples are working!
I have two suggestions for refactoring (to let fewer exceptional cases pass through) but pre-approving.
No description provided.