Fix AllocRefValue
#773
Merged
Fix AllocRefValue
#773
+40
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothtamas28
commented
Oct 24, 2025
Comment on lines
+130
to
+134
| metadata=Metadata( | ||
| size=metadata_size, | ||
| pointer_offset=0, | ||
| origin_size=metadata_size, | ||
| ), |
There was a problem hiding this comment.
I made this assumption based on the previous version of AllocRevValue.to_kast(), I don't know if it makes sense though.
There was a problem hiding this comment.
I think this makes sense, when we decode we won't ever have an offset, and the origin_size should be the same as the size field IIUC.
Comment on lines
+143
to
+147
| metadata=Metadata( | ||
| size=actual_size, | ||
| pointer_offset=0, | ||
| origin_size=actual_size, | ||
| ), |
Stevengre
reviewed
Oct 27, 2025
| class NoMetadata(MetadataSize): | ||
| def to_kast(self) -> KInner: | ||
| return KApply('noMetadata') | ||
| return KApply('noMetadataSize') |
There was a problem hiding this comment.
Thank you for changing this! I encountered a problem when running spl-token proof because of this.
tothtamas28
force-pushed
the
metadata-fixes
branch
2 times, most recently
from
9ee78e1 to
89d4136
Compare
Stevengre
approved these changes
Oct 27, 2025
Stevengre
force-pushed
the
metadata-fixes
branch
from
89d4136 to
fd0250e
Compare
automergerpr-permission-manager bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
Blocked on: * ~#773~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.