Skip to content

NO OP rules for compiler hint intrinsics #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 11, 2025
Merged

NO OP rules for compiler hint intrinsics #828

merged 7 commits into from
Nov 11, 2025

Conversation

@dkcumming
Copy link
Collaborator

@dkcumming dkcumming commented Nov 10, 2025 •
edited
Loading

Some instrinsics do not affect the semantics of the compiled program but are hints to the compiler. In our semantics these intrinsics are NO OPs where the call is ignored and current continuation (<k> cell) moves onto the next term in the sequence.

In particular there are rules implemented for these intrinsics:

  • cold_path
  • prefetch_read_data
  • prefetch_write_data
  • prefetch_read_instruction
  • prefetch_write_instruction

By handling cold_path we also support likely and unlikely which are MonoItemFn that call the cold_path instrinic.

This PR also refactors the intrinsics into their only file intrinsics.md.

closes #802

@dkcumming dkcumming self-assigned this Nov 10, 2025
jberthold
jberthold approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@jberthold jberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and good refactoring to split it out of kmir.md!
BTW we also need assert_inhabited BTW, but implementing its idea requires type information that we don't really have. We can make it a NO OP, though (it "is not guaranteed to ever panic").

kmir/src/kmir/kdist/mir-semantics/intrinsics.md
# Rust Intrinsic Functions in K

```k
// This looks like a circular import but only module KMIR in kmir.md imports KMIR-INTRINSICS
Copy link
Member

@jberthold jberthold Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should split out the control flow in kmir.md into its own file at some point (not an urgent matter)

@jberthold
Copy link
Member

jberthold commented Nov 10, 2025

Needs test adaptation, checked_arithmetic-fail succeeds now.

@automergerpr-permission-manager automergerpr-permission-manager bot merged commit 8ef12df into master Nov 11, 2025
7 checks passed
@automergerpr-permission-manager automergerpr-permission-manager bot deleted the dc/no-op-intrinsics branch November 11, 2025 02:36
This was referenced Nov 11, 2025
Closed
Merged
dkcumming added a commit that referenced this pull request Nov 11, 2025
@dkcumming
Update feature/p-token with master (manually merged) (#833)
a6cb03c 
- #826
- #828

Conflict with imports correct manually
@dkcumming dkcumming mentioned this pull request Nov 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jberthold jberthold jberthold approved these changes

@sskeirik sskeirik Awaiting requested review from sskeirik

@Stevengre Stevengre Awaiting requested review from Stevengre

@JuanCoRo JuanCoRo Awaiting requested review from JuanCoRo

Assignees

@dkcumming dkcumming

Labels

automerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement more of the hint/no-op intrinsics

3 participants

@dkcumming @jberthold