--terminate-on-thunk option to stop execution on thunk
#834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also sets `--break-on-thunk` in cut point rules as the terminal rule needs the `thunk` on the top of the `<k>` cell to match
dkcumming
requested review from
JuanCoRo,
Stevengre,
jberthold,
sskeirik and
tothtamas28
tothtamas28
approved these changes
Nov 11, 2025
Co-authored-by: Tamás Tóth <tothtamas28@users.noreply.github.com>
automergerpr-permission-manager
bot
deleted the
dc/terminate-on-thunk
branch
JuanCoRo
added a commit
that referenced
this pull request
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
--terminate-on-thunkoption to thekmircli. Enabling this option will mean that execution will terminate if athunkis applied.The technical details of how this applied is a cut point rule for
thunkis applied which meansthunkwill be at the top of the<k>cell. Then the terminal rule is able to match thatthunk.