add simplification to remove #mapOffset from symbolic key bytes lists
#836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sskeirik
approved these changes
Nov 11, 2025
Collaborator
sskeirik
left a comment
sskeirik
left a comment
There was a problem hiding this comment.
This looks good base on the semantics of #mapOffset and #adjustRef where #adjustRef is a no-op on values that do not contain references or pointers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#mapOffsetadjusts the offset parameter of references and pointers in argument lists when values containing them are read from or written to outer stack frames. This happens to the bytes ofPubKeydata in P-token, which is known to be allInteger(_, 8, false)but abstracted in a list-sorted variable.Without this simplification, a path condition
KEYBYTES ==K <some key>will not imply#mapOffset(KEYBYTES) ==K <some key>. This was causing vacuous branches which end up inassert_failedcalls.Some proofs were failing before and are passing with this simplification.