Refactor str paths to Path
#293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbyalcinkaya
commented
Jun 24, 2024
Comment on lines
-63
to
-77
| def load_input_json(test_dir: str) -> dict: | ||
| try: | ||
| with open(join(test_dir, INPUT_FILE_NAME)) as f: | ||
| return json.load(f) | ||
| except FileNotFoundError: | ||
| raise FileNotFoundError(f'{INPUT_FILE_NAME!r} not found in "{test_dir!r}"') from None | ||
|
|
||
|
|
||
| def find_test_wasm_path(test_dir: str) -> str: | ||
| test_wasm_path = glob.glob(test_dir + '/output/*.wasm') | ||
| # TODO this loads the first wasm file in the directory. what if there are multiple wasm files? | ||
| if test_wasm_path: | ||
| return test_wasm_path[0] | ||
| else: | ||
| raise ValueError(f'WASM file not found: {test_dir}/output/?.wasm') |
Member
Author
There was a problem hiding this comment.
I'll add these functions to kasmer-multiversx in a follow-up PR.
tothtamas28
approved these changes
Jun 24, 2024
| abi_paths = glob.glob(test_dir + '/output/*.abi.json') | ||
| # TODO this loads the first wasm file in the directory. what if there are multiple wasm files? | ||
| def get_test_endpoints(test_dir: Path) -> Mapping[str, tuple[str, ...]]: | ||
| abi_paths = glob.glob(str(test_dir) + '/output/*.abi.json') |
Contributor
There was a problem hiding this comment.
Consider using Path.glob instead: https://docs.python.org/3/library/pathlib.html#pathlib.Path.glob
|
|
||
| code = get_contract_code(tx['contractCode'], filename) | ||
| assert isinstance(code, str) | ||
| assert isinstance(code, Path) |
Contributor
There was a problem hiding this comment.
Suggested change
| assert isinstance(code, Path) | |
| assert code is not None |
Co-authored-by: Tamás Tóth <tothtamas28@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the
scenarioandkasmermodules to usePathinstead ofstrfor variables representing file and directory paths.