This repository was archived by the owner on Apr 25, 2024. It is now read-only.
Validate KBuild options in Kompile #792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothtamas28
approved these changes
Dec 19, 2023
Collaborator
tothtamas28
left a comment
tothtamas28
left a comment
There was a problem hiding this comment.
Great refactoring! ✨
I left a few comments in case you'd like to take this one step further, but feel free to merge as-is.
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
fixes: #771 This consolidates parameter validation into the Kompile classes so they don't have to be declared a second time in KBuild. --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
fixes: #771 This consolidates parameter validation into the Kompile classes so they don't have to be declared a second time in KBuild. --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
fixes: #771 This consolidates parameter validation into the Kompile classes so they don't have to be declared a second time in KBuild. --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
fixes: #771 This consolidates parameter validation into the Kompile classes so they don't have to be declared a second time in KBuild. --------- Co-authored-by: devops <devops@runtimeverification.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #771
This consolidates parameter validation into the Kompile classes so they don't have to be declared a second time in KBuild.