feat(spl): add domain data test #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
dkcumming
reviewed
Oct 29, 2025
Collaborator
dkcumming
left a comment
dkcumming
left a comment
There was a problem hiding this comment.
Makes sense to me, I assume you are still going or it wouldn't be a draft and it is missing cheatcode_is_*. But looks good so far
Comment on lines
+234
to
+239
| // Compare Rent from Sysvar::get vs account; fallback if not a real rent sysvar | ||
| let sysrent = solana_rent::Rent::get().unwrap(); | ||
| let min_a = sysrent.minimum_balance(10); | ||
| let prent = solana_rent::Rent::from_account_info(rent).unwrap_or(sysrent); | ||
| let min_b = prent.minimum_balance(10); | ||
| assert_eq!(min_a, min_b); |
Collaborator
There was a problem hiding this comment.
I assume this makes sense but I actually don't know for sure tbh. Maybe this would be a good thing to ask Febo actually
Collaborator
There was a problem hiding this comment.
Actually I checked and recall that it checks that the public key matches so this is fair
jberthold
reviewed
Oct 29, 2025
jberthold
reviewed
Oct 29, 2025
Co-authored-by: Jost Berthold <jost.berthold@gmail.com>
Co-authored-by: Jost Berthold <jost.berthold@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.