feat: enhance runnable command placeholders#21978
Merged
ChayimFriedman2 merged 2 commits intorust-lang:masterfrom Apr 9, 2026
Merged
feat: enhance runnable command placeholders#21978ChayimFriedman2 merged 2 commits intorust-lang:masterfrom
ChayimFriedman2 merged 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
requested changes
Apr 7, 2026
|
|
||
| let exact = match kind { | ||
| RunnableKind::Test { test_id } | RunnableKind::Bench { test_id } => match test_id { | ||
| TestId::Path(_) => "", |
Contributor
There was a problem hiding this comment.
TestId::Path is one specific test and needs --exact, modules are RunnableKind::TestMod.
Contributor
Author
There was a problem hiding this comment.
yep, had it backward. also fixed include_ignore cond while I was at it, is this the correct behavior ?
ChayimFriedman2
requested changes
Apr 7, 2026
ChayimFriedman2
approved these changes
Apr 9, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add new placeholders for
overrideCommandsettings:${exact}(--exactfor single targets, empty for modules) and${include_ignored}(--include-ignoredfor tests, empty otherwise). Also documents the existing${test_name}placeholder.allows nextest-style overrides:
Existing
${executable_args}configs are unaffected.Closes #21137