Replace mod path to ast with factory where possible#22137
Merged
ChayimFriedman2 merged 14 commits intorust-lang:masterfrom Apr 22, 2026
Merged
Conversation
…actory and also restructured it
…tor_with_factory and also restructured it
…also restructured it
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
approved these changes
Apr 22, 2026
rustbot
removed
the
S-waiting-on-review
This was referenced Apr 22, 2026
asukaminato0721
pushed a commit
to asukaminato0721/rust-analyzer
that referenced
this pull request
Apr 22, 2026
…-mod-path-to-ast-with-factory-where-possible Replace mod path to ast with factory where possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started migrating most assists that use
mod_path_to_astto their*_with_factoryvariants. During this process, I added a*_with_factoryversion foruse_trivial_constructorand replaced it where needed. We also migratedconvert_into_to_from.rs, as it was usingmod_path_to_ast.part of #15710 and #18285