Skip to content

feat: add diagnostic for E0735#22145

Merged
ChayimFriedman2 merged 2 commits intorust-lang:masterfrom
ada4a:diag-E0735
Apr 22, 2026
Merged

feat: add diagnostic for E0735#22145
ChayimFriedman2 merged 2 commits intorust-lang:masterfrom
ada4a:diag-E0735

Conversation

@ada4a
Copy link
Copy Markdown
Contributor

@ada4a ada4a commented Apr 22, 2026

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2026
ada4a
ada4a commented Apr 22, 2026
View reviewed changes
Comment thread crates/ide-diagnostics/src/handlers/generic_default_refers_to_self.rs
ada4a
ada4a commented Apr 22, 2026
View reviewed changes
Comment thread crates/ide-diagnostics/src/handlers/generic_default_refers_to_self.rs
ada4a
ada4a commented Apr 22, 2026
View reviewed changes
Comment thread crates/hir-ty/src/lower/path.rs
@ChayimFriedman2
Copy link
Copy Markdown
Contributor

ChayimFriedman2 commented Apr 22, 2026

Please don't assign PRs to me just because I have authored their issue. I review PRs when I have time and will. Only assign to me if I had previous interaction with the PR or its contents, or had explicitly expressed interest in reviewing it.

@ada4a
Copy link
Copy Markdown
Contributor Author

ada4a commented Apr 22, 2026 •
edited
Loading

Please don't assign PRs to me just because I have authored their issue. I review PRs when I have time and will. Only assign to me if I had previous interaction with the PR or its contents, or had explicitly expressed interest in reviewing it.

Oh, sorry, thanks for letting me know. Should I reroll (r?) then? Or, more generally, should I explicitly r?, or will someone come look at the PR by themselves?

@ChayimFriedman2
Copy link
Copy Markdown
Contributor

ChayimFriedman2 commented Apr 22, 2026

I don't want to be explicitly assigned, I will look at PRs when I want. Other members may have different wishes.

@ChayimFriedman2
Copy link
Copy Markdown
Contributor

ChayimFriedman2 commented Apr 22, 2026

But you don't need to reroll this PR.

ChayimFriedman2
ChayimFriedman2 approved these changes Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

View changes since this review

@ChayimFriedman2 ChayimFriedman2 added this pull request to the merge queue Apr 22, 2026
Merged via the queue into rust-lang:master with commit 2147146 Apr 22, 2026
18 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2026
@ada4a ada4a deleted the diag-E0735 branch April 22, 2026 23:22
@rustbot rustbot mentioned this pull request Apr 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChayimFriedman2 ChayimFriedman2 ChayimFriedman2 approved these changes

Assignees

@ChayimFriedman2 ChayimFriedman2

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ada4a @ChayimFriedman2 @rustbot