Skip to content

Conversation

juliangehring
Copy link
Contributor

@juliangehring juliangehring commented Jun 22, 2019

Allow setting the compression level when writing BAM/CRAM files. Adds

  • Writer.set_compression_level()
  • CompressionLevel enum to specify the desired compression level
  • CompressionLevelError error enum
  • test cases

@coveralls
Copy link

Pull Request Test Coverage Report for Build 644

  • 49 of 55 (89.09%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 60.163%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bam/mod.rs 49 55 89.09%
Totals Coverage Status
Change from base Build 643: 0.1%
Covered Lines: 21474
Relevant Lines: 35693

💛 - Coveralls

@juliangehring
Copy link
Contributor Author

Should resolve #142.
@wwood, what do you think?

@wwood
Copy link

wwood commented Jun 28, 2019

Sure, looks good, for what my opinion is worth. This is enough for my use case, though I thought you were planning bcf too?

Copy link
Contributor

@johanneskoester johanneskoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, thank you!

@johanneskoester johanneskoester merged commit 70b4688 into rust-bio:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants