Skip to content

check for OOM during realloc & panic, rather than proceeding with null #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2019
Merged

check for OOM during realloc & panic, rather than proceeding with null #148

merged 2 commits into from
Jul 20, 2019

Conversation

pmarks
Copy link
Contributor

@pmarks pmarks commented Jul 14, 2019

Will avoid segfault and be easier to diagnose issues if you run into OOM.

@pmarks pmarks requested a review from johanneskoester July 14, 2019 15:39
johanneskoester
johanneskoester approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@johanneskoester johanneskoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@johanneskoester
Copy link
Contributor

It just needs a cargo fmt now.

@pmarks pmarks mentioned this pull request Jul 15, 2019
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 652

  • 7 of 8 (87.5%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 60.147%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bam/record.rs 7 8 87.5%
Files with Coverage Reduction New Missed Lines %
src/bam/buffer.rs 1 55.29%
Totals Coverage Status
Change from base Build 647: -0.02%
Covered Lines: 21472
Relevant Lines: 35699
💛 - Coveralls

@pmarks
Copy link
Contributor Author

pmarks commented Jul 16, 2019

@johanneskoester fmt is fixed. I don't think we can really test this codepath in CI unfortunately.

@pmarks
Copy link
Contributor Author

pmarks commented Jul 20, 2019

@johanneskoester - ok to merge this?

@johanneskoester johanneskoester merged commit 194c26d into master Jul 20, 2019
@johanneskoester
Copy link
Contributor

Thanks!

@johanneskoester johanneskoester deleted the pmarks/saftey branch July 20, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanneskoester johanneskoester johanneskoester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmarks @johanneskoester @coveralls