Skip to content

Conversation

pmarks
Copy link
Contributor

@pmarks pmarks commented Jul 15, 2019

As discussed in #147. Applies on top of #148.

@pmarks pmarks requested a review from johanneskoester July 15, 2019 14:30
@coveralls
Copy link

Pull Request Test Coverage Report for Build 653

  • 12 of 14 (85.71%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 60.146%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bam/record.rs 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
src/bam/buffer.rs 1 55.29%
Totals Coverage Status
Change from base Build 647: -0.02%
Covered Lines: 21471
Relevant Lines: 35698

💛 - Coveralls

@pmarks
Copy link
Contributor Author

pmarks commented Jul 28, 2019

@johanneskoester anything else needed here?

Copy link
Contributor

@johanneskoester johanneskoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@johanneskoester johanneskoester merged commit dcb0fd3 into master Jul 29, 2019
@johanneskoester johanneskoester deleted the pmarks/no-result-aux branch July 29, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants