Update just fmt to format test and verify
#356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
previously approved these changes
Sep 10, 2025
|
Needs rebase, I merged #358 first because I thought it would be easier to rebase this one. Tip, when you rebase just reset the index and then run the formatter again. That way you should keep the commit log and patch series structure. |
Running `just fmt` only formats modules in the workspace, and not `integration_test` and `verify`. Add a line for both of these modules so that they are formatted when running `just fmt`.
Run `just fmt` in the integration_test directory to format the code. Format only, no code changes.
Run `just fmt` in the verify directory to format the code. Format only, no code changes.
jamillambert
force-pushed
the
0910-just-fmt-test-verify
branch
from
b6f827b to
e608af9
Compare
|
Rebased, first two commits the same. Reran just fmt on the last commit in verify. |
tcharding
approved these changes
Sep 11, 2025
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
…erify
e608af915a1bba64970247e592cc383f0ed8c906 Run the formatter in verify (Jamil Lambert, PhD)
e678deb4a6cc83d9e4d87ced312d1df2257d42cb Run the formatter in integration_test (Jamil Lambert, PhD)
7d2510cdf0444754900bbd41ad7c2ea9c158136e Update justfile to format tests and verify (Jamil Lambert, PhD)
Pull request description:
Running `just fmt` only formats modules in the workspace, and not `integration_test` and `verify`.
- Add a line for both of these modules so that they are formatted when running `just fmt`.
- Format `integration_test`.
- Format `verfiy`.
ACKs for top commit:
tcharding:
ACK e608af915a1bba64970247e592cc383f0ed8c906
Tree-SHA512: ea753ec984e1aa406ac899bfa48e11860cc34af9e87ac48e6504260632643aa877ded2f39c9ec48191ce2b632438b01ee4ab9ea5e586cb920783e46fefab3ba4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
just fmtonly formats modules in the workspace, and notintegration_testandverify.just fmt.integration_test.verfiy.