Update verify to check for model vs no model #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify does not correctly check that the RPCs state if they are modelled or not consistently between verify and the types table. Which meant that a lot are different between the two. Go through all of them and make them both match what is done for that RPC.
The current verify does not check that the RPCs are marked as modelled or not consistently between the verify and the types table. Change it so that it does.
tcharding
approved these changes
Sep 10, 2025
|
Nice one man. |
blaze-smith470pm
added a commit
to blaze-smith470pm/corepc
that referenced
this pull request
Sep 26, 2025
… model
42fc2c4dbd09291aae95e170c9c02e2119f45501 Update verify to check for model vs no model (Jamil Lambert, PhD)
7faee78e97c939449aa5545e8dddb5ceabbf7008 Fix verify and types tags for model or not (Jamil Lambert, PhD)
Pull request description:
Verify does not correctly check that the RPCs state if they are modelled or not consistently between `verify` and the `types` table.
Which meant that a lot are different between the two.
- Go through all of them and make them both match what is done for that RPC.
- Update `verify` to check that modelled vs no model matches.
Closes #144
ACKs for top commit:
tcharding:
ACK 42fc2c4dbd09291aae95e170c9c02e2119f45501
Tree-SHA512: bce257b9a82d17c915527e2518debe5824d214f4601c48746bcf890f0ae37f3add71cd59b2660d30a4ea8d0759ca297211edd847c6fbad09ec15ccc71f93f2a1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify does not correctly check that the RPCs state if they are modelled or not consistently between
verifyand thetypestable.Which meant that a lot are different between the two.
verifyto check that modelled vs no model matches.Closes #144