Skip to content

Commit fddecd9

Browse files
committed
fix: MSRV test
The MSRV test on master was failing for a while. Since MSRV is the reason to keep unicode-normalization pinned I fixed it to demonstrate that even without pinning downstream consumers can maintain the current MSRV.
1 parent b100bf3 commit fddecd9

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ zeroize = { version = "1.5", features = ["zeroize_derive"], optional = true }
5050

5151
# Unexported dependnecies
5252
bitcoin_hashes = { version = ">=0.12, <=0.13", default-features = false }
53-
unicode-normalization = { version = "=0.1.22", default-features = false, optional = true }
53+
unicode-normalization = { version = "0.1.22", default-features = false, optional = true }
5454

5555
[dev-dependencies]
5656
# Enabling the "rand" feature by default to run the benches

README.md

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,14 @@ Use the `all-languages` feature to enable all languages.
3131

3232
This crate supports Rust v1.41.1 and up and works with `no_std`.
3333

34-
When using older version of Rust, you might have to pin the version of the
35-
`bitcoin_hashes` crate used as such:
36-
```
37-
$ cargo update --package "bitcoin_hashes" --precise "0.12.0"
34+
When using older version of Rust, you might have to pin the versions of several crates, for an up-to-date list refer to [`contrib/test.sh`](contrib/test.sh):
35+
36+
```bash
37+
cargo update --package "bitcoin_hashes" --precise "0.12.0"
38+
cargo update --package "rand" --precise "0.6.0"
39+
cargo update --package "libc" --precise "0.2.151"
40+
cargo update --package "tinyvec" --precise "1.6.0"
41+
cargo update --package "unicode-normalization" --precise "0.1.22"
3842
```
3943

4044
If you enable the `zeroize` feature the MSRV becomes 1.51.

contrib/test.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ rustc --version
1010
# Pin dependencies as required if we are using MSRV toolchain.
1111
if cargo --version | grep "1\.41"; then
1212
cargo update --package "bitcoin_hashes" --precise "0.12.0"
13+
cargo update --package "rand" --precise "0.6.0"
14+
cargo update --package "libc" --precise "0.2.151"
15+
cargo update --package "tinyvec" --precise "1.6.0"
16+
cargo update --package "unicode-normalization" --precise "0.1.22"
1317
fi
1418

1519
echo "********* Testing std *************"
@@ -37,7 +41,7 @@ then
3741
cargo build --verbose --no-default-features
3842

3943
# Build std + no_std, to make sure they are not incompatible
40-
cargo build --verbose
44+
cargo build --verbose
4145
# Test no_std
4246
cargo test --verbose --no-default-features
4347

0 commit comments

Comments
 (0)