Deserialize hexes without allocating intermediate Vec<u8>
#241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `HexIterator` is `Read` we can feed him directly to `consensus_decode` without the intermediate step of converting the hex string to `Vec<u8>`
|
I love this :) |
stevenroose
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
HexIteratorisReadwe can feed it directly toconsensus_decodewithout the intermediate step of converting the hex string to
Vec<u8>Could be applied on other fields, but they are now deserialized with
serde_hexasVec<u8>, we may consider keeping themStringand then converting them withdeserialize_hex