-
Notifications
You must be signed in to change notification settings - Fork 255
bugfix : problems with compiling ron and base64 on nix rustc 1.92.0-nightly (839222065 2025-10-05) #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix : problems with compiling ron and base64 on nix rustc 1.92.0-nightly (839222065 2025-10-05) #713
Conversation
|
This is titled "bugfix" but it isn't clear what the bug is. The change looks instead like an attempt at an upgrade but seems incomplete (since using a git dep). Could you please clarify what is going on. Note that we generally ask for this to be done in an issue and get buy-in on a solution before posting a PR. |
|
Yes sorry I thought I included the error and the patch basically there's a
Cascade of patches where Ron is using a broken version of base64 and I had
to upgrade all of them and make changes to all of them to get it to compile
with the latest compiler I'll provide more details in a minute
…On Tue, Nov 11, 2025, 20:39 Ed Page ***@***.***> wrote:
*epage* left a comment (rust-cli/config-rs#713)
<#713 (comment)>
This is titled "bugfix" but it isn't clear what the bug is. The change
looks instead like an attempt at an upgrade but seems incomplete (since
using a git dep).
Could you please clarify what is going on. Note that we generally ask for
this to be done in an issue and get buy-in on a solution before posting a
PR.
—
Reply to this email directly, view it on GitHub
<#713 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD5KQ2KPGTRY5KZ7AN3T2DL34KFT3AVCNFSM6AAAAACL2RHYAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKMJZGQ4DIMBVGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
see ron-rs/ron#590 /nix/store/k0db47fx7mdl8bajzhk05x8414gf5w03-rustc/bin/rustc --version |
reported some issues rust-cli/config-rs#713 marshallpierce/rust-base64#290 ron-rs/ron#590
|
That is a warning, why does it matter? |
This is an error : |
|
So this works for me, it was blocking me, hopefullly it helps the next poor man down the line |
|
I'm assuming that error isn't what you would see with our published packages but from upgrading to an incompatible version of I'm asking why that warning in base64 that started this matters. It is a regular occurrence for rustc upgrades to show new lints. This isn't a dance that is practical to go through for every package everytime. Cargo actually silences warnings from dependencies through a "cap lint" feature in the compiler. |
|
I don't know but it was blocking my build you know if it's not an issue
then you can ignore you can close it it's not a problem I'm just trying to
be a good citizen here I'm going to downgrade the compiler to an older
version
…On Tue, Nov 11, 2025, 22:22 Ed Page ***@***.***> wrote:
*epage* left a comment (rust-cli/config-rs#713)
<#713 (comment)>
I'm assuming that error isn't what you would see with our published
packages but from upgrading to an incompatible version of ron to upgrade
base64 to resolve a warning.
I'm asking why that warning in base64 that started this matters. It is a
regular occurrence for rustc upgrades to show new lints. This isn't a dance
that is practical to go through for every package everytime. Cargo actually
silences warnings from dependencies through a "cap lint" feature in the
compiler.
—
Reply to this email directly, view it on GitHub
<#713 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD5KQ2MQ3H6ZIERCJHVNLTL34KRZFAVCNFSM6AAAAACL2RHYAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKMJZG4YTSOJRG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
using a recent compiler nix rustc 1.92.0-nightly (839222065 2025-10-05) on nix with latest version of ron (because of base64 also breaking)