Skip to content

Return the number of bytes used in the deserialization process #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2020
Merged

Return the number of bytes used in the deserialization process #26

merged 1 commit into from
Dec 11, 2020

Conversation

@MabezDev
Copy link
Member

@MabezDev MabezDev commented Feb 21, 2020

Particularly useful when using smoltcp's closure based socket API.

@MabezDev MabezDev requested a review from japaric February 21, 2020 12:29
eldruin
eldruin requested changes Nov 22, 2020
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MabezDev! Could you add an entry to the Changelog as well?

eldruin
eldruin reviewed Dec 10, 2020
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the changelog entry, this looks good to me.
It should be noted that this contains a breaking change, so we need to bump the version appropriately when this lands.

@MathiasKoch
Copy link
Collaborator

MathiasKoch commented Dec 11, 2020

I will merge these and open a new PR with combined changelog entries

@MathiasKoch MathiasKoch merged commit a0bc7e9 into rust-embedded-community:master Dec 11, 2020
MathiasKoch added a commit to MathiasKoch/serde-json-core that referenced this pull request Dec 11, 2020
@MathiasKoch
Rebase on master and fix tests following the merge of rust-embedded-c…
0e5bbfb 
…ommunity#26
@MathiasKoch MathiasKoch mentioned this pull request Dec 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eldruin eldruin eldruin requested changes

@japaric japaric Awaiting requested review from japaric

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MabezDev @MathiasKoch @eldruin