-
Notifications
You must be signed in to change notification settings - Fork 12
Add struct Board
for MPS3-AN536
#74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 nits, I prioritize readable names. I think gic
is fine as it's the ARM acronym as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a stab at safety comments as well :)
Removes a bunch of duplicate code from the examples.
Co-authored-by: Emil Fresk <emil.fresk@gmail.com>
More readable than pgt and vgt.
2b3ccc4
to
e3febf4
Compare
Rebased on main after #72 was merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Holds all the hardware specific to the MPS3-AN536, making the examples simpler.