This repository was archived by the owner on Dec 2, 2020. It is now read-only.
Actually use heprintln, and unwrap it #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @thejpster (rust_highfive has picked a reviewer for you, use r? to override) |
bors bot
added a commit
that referenced
this pull request
Aug 23, 2019
43: Actually use heprintln, and unwrap it r=adamgreig a=nickray I'm sorry, it's me again... - std::dbg panics on failure, given `dbg!` is advertised as "quick n' dirty" I think this behaviour makes sense here too (no need to type `.unwrap()` everywhere, no unused Result warnings) - also to be more analogous, actually use `heprintln` (as already advertised in documentation) - I went ahead and added the nod to 2018 edition missing last time Co-authored-by: Nicolas Stalder <n@stalder.io>
Contributor
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry, it's me again...
dbg!is advertised as "quick n' dirty" I think this behaviour makes sense here too (no need to type.unwrap()everywhere, no unused Result warnings)heprintln(as already advertised in documentation)