Add more utilities to the Docker images.#226
Conversation
This PR adds the following utilities to all docker containers - these allows the utilities to be used in `build.rs` while cross-compiling: g++, git, automake, libtool, m4, autoconf, make, file, binutils.
|
Thanks |
|
bors: try |
tryTimed out |
|
Finally! This is really useful addition to the images. Especially with |
|
bors: try |
|
🔒 Permission denied Existing reviewers: click here to make gnzlbg a reviewer |
|
@mpapierski yes, i need this in the |
|
@gnzlbg not sure why the build timed out, but there were some failures: https://travis-ci.org/rust-embedded/cross/builds/453101321 |
Details
Details
Details
Details |
|
From the list of packages, the only weird one that could be causing this is |
|
Could have added a link instead of pasting the entire thing |
|
Sorry, I've put them in detail blocks, but I can't link to the relevant lines because the logs exceed 10k lines in travis :/ |
|
You can paste it on paste.rs and link it here |
|
@gnzlbg if you want, you can open a PR against master that comments out all the other tests, and we can do a quick bors try on that, to see if it was your changes or something else that is failing (and just close that PR without Edit: words |
|
So I've removed the g++ package from here. @jamesmunns if this fails again we could do that. |
|
@jamesmunns if that was the case then we would have got the same errors on the other prs it the build in general. |
|
bors try |
|
Still failing. I'll open a separate PR just with the failing targets to triple-check that master is passing. The last PR that was run before these ones is from 7 days ago, that's a couple of nightlies / libc versions that could have broken any of these targets. You might want to enable a cron job in travis to run the tests of the master branch daily to detect these kind of things. |
|
bors cancel |
tryBuild failed |
|
#227 shows that the builds that are broken have nothing to do with this PR. See https://travis-ci.org/rust-embedded/cross/builds/453241344 As mentioned, adding a cron job to travis to run the tests on master daily would save us some headaches like this. |
|
I'm okay with merging this |
|
Problem is we can't merge this PR if the tests don't pass. So we are blocked on that. The way out would be to disable bors temporarily (or the checks) merge it and revert the settings back to normal. |
|
I'll try to send a PR to fix freebsd, but that won't be mergeable either due to the failures in the other targets. |
|
I think the way out will be is to either temporarily remove these architectures from the CI process or allow them to fail. |
|
We depend on these working for |
|
Uhmm yes. We could remove them temporarily till we fix the issues and then add them back so that it doesn't block other PRs |
|
so do we merge this as is? |
|
@gnzlbg we can't, since the build has to pass for bors to merge it. We can perhaps disable bors, but I don't have permissions for that |
|
We could send a PR to make these targets |
|
Yah that or commenting the architectures in the config is fine (they are going to fail anyway for now so no point checking them). |
|
bors: try |
tryTimed out |
|
@jamesmunns can you add travis/appveyor to pull request required checks? With the current setup it is hard to debug when the build failed (or timed out) |
|
bors: try |
tryTimed out |
|
bors: r+ |
226: Add more utilities to the Docker images. r=Dylan-DPC a=gnzlbg This PR adds the following utilities to all docker containers - these allows the utilities to be used in `build.rs` while cross-compiling: g++, git, automake, libtool, m4, autoconf, make, file, binutils. Co-authored-by: gnzlbg <gonzalobg88@gmail.com>
Timed out |
|
none of the travis builds has failed or timed out, but bors has a timeout of 3 hours and it has been almost 4 hours since bors r+ was issued and there are still a few travis builds that need to complete. The bors timeout could be doubled and then this should be able to land. |
|
yeah. Was trying to see if we could solve this issue without having to increase the timeout, and manage to build it within the 3 hour period but it seems it isn't possible. |
|
bors: r+ |
226: Add more utilities to the Docker images. r=Dylan-DPC a=gnzlbg This PR adds the following utilities to all docker containers - these allows the utilities to be used in `build.rs` while cross-compiling: g++, git, automake, libtool, m4, autoconf, make, file, binutils. Co-authored-by: gnzlbg <gonzalobg88@gmail.com>
Build succeeded |
This PR adds the following utilities to all docker containers - these allows the
utilities to be used in
build.rswhile cross-compiling: g++, git, automake,libtool, m4, autoconf, make, file, binutils.