Deserialize maps as maps #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The maps are already being serialized as maps, and serde_json will detect that despite us claiming that maps are seqs, it falls back to parsing them as maps; however, serde-json-core does not have that fallback logic, so it makes more sense to give the correct hint here (especially when this is merged: rust-embedded-community/serde-json-core#23)
Member
|
Thanks for the PR. I suppose this is technically a breaking change but since serde-json can deserialize back what you get from serializing a map I don't think anyone was relying on the current behavior. bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 17, 2019
125: Deserialize maps as maps r=japaric a=dflemstr The maps are already being serialized as maps, and serde_json will detect that despite us claiming that maps are seqs, it falls back to parsing them as maps; however, serde-json-core does not have that fallback logic, so it makes more sense to give the correct hint here (especially when this is merged: rust-embedded-community/serde-json-core#23) Co-authored-by: David Flemström <david.flemstrom@gmail.com>
Contributor
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maps are already being serialized as maps, and serde_json will detect
that despite us claiming that maps are seqs, it falls back to parsing them
as maps; however, serde-json-core does not have that fallback logic, so it
makes more sense to give the correct hint here (especially when this is
merged: rust-embedded-community/serde-json-core#23)