X86: support x86 (i386) and x86_64 #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Nice, thanks! Do you plan to release it soon? Shall I wait or just reference the git repository in my project? |
Contributor
Author
|
@adamgreig hi Adam! As far as I know, Andre contacted you that I'm interested in helping out as a maintainer. So, how do we want to continue here? |
Contributor
Author
|
ping @adamgreig ? |
Member
|
@phip1611 I'm so sorry for the wait, this PR thread totally dropped off my radar. I've published 3.0.2 with your PR. We would love help maintaining this crate. Right now it's part of the embedded Rust working group, but it's not clear which team maintains it; ideally to help maintain you'd join one of the working group teams. I'll raise the issue at our meeting next week and see if there's a team we can move the crate to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I'm developing for a x86 target and the library doesn't work there. I tested the change locally and it works fine.
Is there any reason for that restriction in the first place?