Skip to content

Conversation

PythonGermany
Copy link
Contributor

@PythonGermany PythonGermany commented Mar 15, 2025

Closes #42
Closes #65
Closes #66

@PythonGermany PythonGermany marked this pull request as ready for review March 15, 2025 21:46
args: --release --target {{ "${{ matrix.job.target }}" }}
tool: cross
- name: Build release binary
run: cross build --locked --release --target {{ "${{ matrix.job.target }}" }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we only use and install cross if use-cross: true? this will make cd more efficient

@marcoieni
Copy link
Member

great improvement, thanks! I left just some minor comments.

PythonGermany and others added 2 commits March 16, 2025 12:46
Co-authored-by: Marco Ieni <11428655+marcoieni@users.noreply.github.com>
@marcoieni marcoieni merged commit 37dda69 into rust-github:main Mar 16, 2025
1 check passed
@marcoieni
Copy link
Member

oops forgot about the cross comment. I created #69

@PythonGermany PythonGermany deleted the replace-unmaintained-actions branch March 16, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Action actions-rs/toolchain is not maintained Action actions-rs/cargo is not maintained replace actions-rs actions

2 participants