Skip to content

Added links to descriptions of XID_start and XID_continue in identifiers section.#48

Merged
steveklabnik merged 4 commits intorust-lang:masterfrom
VinithKrishnan:master
Apr 26, 2017
Merged

Added links to descriptions of XID_start and XID_continue in identifiers section.#48
steveklabnik merged 4 commits intorust-lang:masterfrom
VinithKrishnan:master

Conversation

@VinithKrishnan
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/identifiers.md Outdated
> character ranges used to form the more familiar C and Java language-family
> identifiers.

Links to Unicode descriptions:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be nicer to use references like the [keywords] and/or [^non_ascii_idents] lines below. You wouldn't need this block; the external links would live on the text itself.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, for the suggestion.I have made the changes.

@mrhota
Copy link
Copy Markdown
Contributor

mrhota commented Apr 26, 2017

@VinithKrishnan I think it's ok to leave the backticks around the words, inside the brackets.

[`XID_start`] blah blah

[`XID_start`]: http://www.example.com

@steveklabnik steveklabnik merged commit b3bedc0 into rust-lang:master Apr 26, 2017
@steveklabnik
Copy link
Copy Markdown
Contributor

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants