Remove unnecessary ci jobs #1163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions Only generating bindings depends on which libclang version we are dealing with. Running the test expectations' layout tests does not change between libclang versions, so these were redundant tests. Note that we have not been testing the expected bindings that differ across libclang versions (the nested sub-directories aren't automatically picked up by cargo) and this commit does not change that.
…ations
This adds a build.rs to generate
#[path="$FILE"]
mod $FILE_AS_IDENT;
for each $FILE in our libclang version-specific directories. We need to do this
to get those files' layout tests to run because cargo doesn't automatically pick
up tests in subdirectories.
emilio
approved these changes
Nov 28, 2017
Contributor
|
@bors-servo r+ |
|
📌 Commit 1c2172f has been approved by |
|
☀️ Test successful - status-travis |
Member
Author
|
Thanks @emilio ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And then in the process I noticed that we weren't running the layout tests for any of the libclang version-specific expectation files, so I also fixed that.
r? @emilio or @pepyakin