Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announce an impending update the Android NDK target #1055

Merged

Conversation

chriswailes
Copy link
Contributor

The language is a little rough. Please let me know if there is anything I can do to improve the announcement.

posts/2022-12-14-android-ndk-update.md Outdated Show resolved Hide resolved
posts/2022-12-14-android-ndk-update.md Outdated Show resolved Hide resolved
@chriswailes chriswailes force-pushed the ndk-update-announcement branch 2 times, most recently from 88d8106 to 96cead8 Compare December 14, 2022 19:00
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it needs the version number before being merged though

posts/2022-12-14-android-ndk-update.md Outdated Show resolved Hide resolved
posts/2022-12-14-android-ndk-update.md Outdated Show resolved Hide resolved
posts/2022-12-14-android-ndk-update.md Outdated Show resolved Hide resolved
posts/2022-12-14-android-ndk-update.md Outdated Show resolved Hide resolved
posts/2022-12-14-android-ndk-update.md Outdated Show resolved Hide resolved
@chriswailes chriswailes force-pushed the ndk-update-announcement branch 2 times, most recently from e0f63f1 to b3ad913 Compare December 15, 2022 17:17
@rylev
Copy link
Member

rylev commented Dec 16, 2022

@chriswailes when would you like this to go live? Could you make sure to update the post's file name to have the right date. Also, don't forget to update the Rust version where the change is supposed to land.

@chriswailes
Copy link
Contributor Author

Is the announcement date up to me? If so, I'll change the date to Monday.

What version would the NDK update land in if the PR is accepted next week? Would that be 1.68?

@jyn514
Copy link
Member

jyn514 commented Dec 16, 2022

1.66 stable just released, so you have a 6 week window to make it into 1.68.

@rylev
Copy link
Member

rylev commented Dec 19, 2022

I think we should wait for the PR to land first, no? It would be a shame for the announcement to happen only for the PR to be delayed.

@Mark-Simulacrum
Copy link
Member

I'm largely happy with merging this before the PR; the worst case is that folks have a little more time. But in practice we've already landed this once I believe, so I don't anticipate it being difficult to do again.

@Mark-Simulacrum
Copy link
Member

#1055 (comment) I think still needs to be resolved.

@chriswailes
Copy link
Contributor Author

#1055 (comment) I think still needs to be resolved.

Yeah, sorry. I'm still not used to GitHub's threading and saw that after I made the last post.

Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
@Mark-Simulacrum Mark-Simulacrum merged commit 6bce895 into rust-lang:master Jan 9, 2023
pietroalbini pushed a commit that referenced this pull request Jan 10, 2023
Announce an impending update the Android NDK target
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2023
bors added a commit to rust-lang/miri that referenced this pull request Jan 23, 2023
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 20, 2024
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants