Get rid of username notification checker in merge commit messages #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
reviewed
Nov 12, 2025
Member
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
Thank you! Left one comment, but otherwise it looks good.
Member
|
Thanks! I'll leave this open until December, if you don't mind, just in case GitHub changes their minds... |
Author
|
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #455
Github is going to implement this feature on December 8th.
So it should work now and when I run on test repo I got a notification from commit message and an email received:
[bncer/boring-test] Check if notification from @opendatavibe happens (2592771)
Inbox
notifications@github.com Unsubscribe
00:34 (13 minutes ago)