Move examples/intrinsics.rs to its own crate
#795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is an interesting situation with the way features get enabled; `testcrate` enables `mangled-names`, but the `intrinsics.rs` example requires this feature be disabled (otherwise the test fails with missing symbols, as expected). This is also the reason that `testcrate` is not a default workspace member, meaning `cargo test` doesn't actually run `testcrate`'s tests; making it a default member would mean that `compiler-builtins/mangled-names` gets enabled when `examples/intrinsics.rs` gets built, due to the way features get unified. Simplify the situation by making moving the example to its own crate as `builtins-test-intrinsics`. This also means `testcrate` can become a default member so it is included in `cargo check` or `cargo test` when run at the workspace root. `testcrate` and `builtins-test-intrinsics` still can't be built at the same time since there isn't a straightforward way to have Cargo build `compiler-builtins` twice with different features. This is a side effect of us using non-additive features, but there isn't really a better option since enabling both mangled and unmangled names would render `builtins-test-intrinsics` useless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is an interesting situation with the way features get enabled;
testcrateenablesmangled-names, but theintrinsics.rsexample requires this feature be disabled (otherwise the test fails with missing symbols, as expected). This is also the reason thattestcrateis not a default workspace member, meaningcargo testdoesn't actually runtestcrate's tests; making it a default member would mean thatcompiler-builtins/mangled-namesgets enabled whenexamples/intrinsics.rsgets built, due to the way features get unified.Simplify the situation by making moving the example to its own crate as
builtins-test-intrinsics. This also meanstestcratecan become a default member so it is included incargo checkorcargo testwhen run at the workspace root.testcrateandbuiltins-test-intrinsicsstill can't be built at the same time since there isn't a straightforward way to have Cargo buildcompiler-builtinstwice with different features. This is a side effect of us using non-additive features, but there isn't really a better option since enabling both mangled and unmangled names would renderbuiltins-test-intrinsicsuseless.