Skip to content

Conversation

@ecstatic-morse
Copy link
Contributor

This builds and publishes the Windows image added in #5 on AppVeyor. As with the Travis CI integration, DOCKER_{PASSWORD,USERNAME} must be set as environment variables.

Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing I'd like to get fixed. I'll setup environment variables soon.

@pietroalbini
Copy link
Member

Configured the environment variables and the permissions, let's try this!

@pietroalbini pietroalbini merged commit 6c76fb2 into rust-lang:master Feb 20, 2019
@ecstatic-morse
Copy link
Contributor Author

Deployment failed.

I believe that DOCKER_USERNAME was not actually set, and --username ended up taking --password-stdin as an argument. I'll push some changes which explicitly check this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants