Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 22, 2024

None of our tests strictly need a sync database connection anymore, and those that were still using one are migrated by this commit to use an async one instead. 🎉

None of our tests strictly need a sync database connection anymore, and those that were still using one are migrated by this commit to use an async one instead.
We only use async connections from now on, so there is no need for the `async_` prefix anymore
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 22, 2024
@Turbo87 Turbo87 enabled auto-merge November 22, 2024 10:38
@Turbo87 Turbo87 merged commit 206e0c5 into rust-lang:main Nov 22, 2024
8 checks passed
@Turbo87 Turbo87 deleted the db-conn branch November 22, 2024 10:43
@codecov
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.35%. Comparing base (f74a14e) to head (c49bf69).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10050      +/-   ##
==========================================
- Coverage   89.40%   89.35%   -0.06%     
==========================================
  Files         295      295              
  Lines       31255    31277      +22     
==========================================
+ Hits        27944    27946       +2     
- Misses       3311     3331      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant