Skip to content

Include email address in support buttons #10144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Include email address in support buttons #10144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3d11e4
Include email address in support buttons
Turbo87 Dec 5, 2024
de7f217
support/crate-report-form: Remove unused styles
Turbo87 Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/support/crate-report-form.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
local-class="report-button"
data-test-id="report-button"
>
Report
Report to <strong>help@crates.io</strong>
</button>
</div>
</form>
10 changes: 5 additions & 5 deletions app/components/support/crate-report-form.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,10 @@
composes: button;
composes: button small from '../../styles/shared/buttons.module.css';
border-radius: var(--space-3xs);
}
font-weight: normal;

.cancel-button {
composes: button;
composes: tan-button small from '../../styles/shared/buttons.module.css';
border-radius: var(--space-3xs);
strong {
margin-left: var(--space-3xs);
font-weight: 500;
}
}
5 changes: 5 additions & 0 deletions app/styles/support.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,9 @@
padding: var(--space-xs) var(--space-s);
height: inherit;
min-height: var(--space-2xl);

strong {
margin-left: var(--space-3xs);
font-weight: 500;
}
}
2 changes: 1 addition & 1 deletion app/templates/support.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
data-test-id="link-email-support"
local-class="link"
>
For all other cases
For all other cases: <strong>help@crates.io</strong>
</a>
</li>
</ul>
Expand Down
6 changes: 3 additions & 3 deletions e2e/acceptance/support.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ test.describe('Acceptance | support page', { tag: '@acceptance' }, () => {
const inquireList = page.getByTestId('inquire-list');
await expect(inquireList).toBeVisible();
await expect(inquireList.locator(page.getByRole('listitem'))).toHaveText(
['Report a crate that violates policies'].concat(['For all other cases']),
['Report a crate that violates policies'].concat(['For all other cases: help@crates.io']),
);

await percy.snapshot();
Expand All @@ -26,7 +26,7 @@ test.describe('Acceptance | support page', { tag: '@acceptance' }, () => {
const inquireList = page.getByTestId('inquire-list');
await expect(inquireList).toBeVisible();
await expect(inquireList.locator(page.getByRole('listitem'))).toHaveText(
['Report a crate that violates policies'].concat(['For all other cases']),
['Report a crate that violates policies'].concat(['For all other cases: help@crates.io']),
);
});

Expand Down Expand Up @@ -57,7 +57,7 @@ test.describe('Acceptance | support page', { tag: '@acceptance' }, () => {
await expect(page.getByTestId('fieldset-crate')).toBeVisible();
await expect(page.getByTestId('fieldset-reasons')).toBeVisible();
await expect(page.getByTestId('fieldset-detail')).toBeVisible();
await expect(page.getByTestId('report-button')).toHaveText('Report');
await expect(page.getByTestId('report-button')).toHaveText('Report to help@crates.io');

await percy.snapshot();
await a11y.audit();
Expand Down
6 changes: 3 additions & 3 deletions tests/acceptance/support-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module('Acceptance | support', function (hooks) {
const listitem = findAll('[data-test-id="inquire-list"] li');
assert.deepEqual(
listitem.map(item => item.textContent.trim()),
['Report a crate that violates policies'].concat(['For all other cases']),
['Report a crate that violates policies'].concat(['For all other cases: help@crates.io']),
);

await percySnapshot(assert);
Expand All @@ -41,7 +41,7 @@ module('Acceptance | support', function (hooks) {
const listitem = findAll('[data-test-id="inquire-list"] li');
assert.deepEqual(
listitem.map(item => item.textContent.trim()),
['Report a crate that violates policies'].concat(['For all other cases']),
['Report a crate that violates policies'].concat(['For all other cases: help@crates.io']),
);
});

Expand Down Expand Up @@ -71,7 +71,7 @@ module('Acceptance | support', function (hooks) {
assert.dom('[data-test-id="fieldset-crate"]').exists();
assert.dom('[data-test-id="fieldset-reasons"]').exists();
assert.dom('[data-test-id="fieldset-detail"]').exists();
assert.dom('[data-test-id="report-button"]').hasText('Report');
assert.dom('[data-test-id="report-button"]').hasText('Report to help@crates.io');

await percySnapshot(assert);
await a11yAudit(axeConfig);
Expand Down
Loading