Fix deprecations #10356
Merged
Fix deprecations #10356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling the store service.
Use `export { default } from 'ember-data/store';` in app/services/store.js instead
[deprecation id: ember-data:deprecate-legacy-imports]
This will be removed in ember-data 6.0.
Turbo87
added
A-frontend 🐹
C-internal 🔧
Turbo87
approved these changes
Jan 9, 2025
Member
Turbo87
left a comment
Turbo87
left a comment
There was a problem hiding this comment.
looks good, aside from the linting issue 😉
eth3lbert
force-pushed
the
fix-deprecations
branch
from
2d0e65c to
974be2d
Compare
Contributor
Author
|
Fixed! I pushed it in a hurry before leaving 🥵 |
…ling the store service.
Use `export { default } from 'ember-data/store';` in app/services/store.js instead
[deprecation id: ember-data:deprecate-legacy-imports]
This will be removed in ember-data 6.0.
…for irregular rules
Please `import { irregular } from '@ember-data/request-utils/string';`
instead to register a custom irregular rule for use with EmberData.
[deprecation id: warp-drive.ember-inflector] This will be removed in
warp-drive 6.0.0.
eth3lbert
force-pushed
the
fix-deprecations
branch
from
974be2d to
287e5e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some deprecations introduced after upgrading Ember Data. Fixes are primarily based on log feedback.