Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Apr 9, 2025

Unfortunately this action needs to perform git fetch operations in some cases, which apparently requires persist-credentials to be true.

@Turbo87 Turbo87 added the C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear label Apr 9, 2025
@Turbo87
Copy link
Member Author

Turbo87 commented Apr 9, 2025

huh... apparently that does not fix it, even though the error message says so 😂

@Turbo87 Turbo87 force-pushed the persist-credentials branch from 83b3a8a to d7d7555 Compare April 9, 2025 08:49
@Turbo87
Copy link
Member Author

Turbo87 commented Apr 9, 2025

fetch-depth: 0 appears to fix it... this makes the checkout action take about 7 seconds, but since we only need to use this once and not for every follow-up job, this seems like a decent tradeoff.

@Turbo87 Turbo87 enabled auto-merge (squash) April 9, 2025 08:51
@Turbo87 Turbo87 force-pushed the persist-credentials branch from d7d7555 to e2cf502 Compare April 9, 2025 08:53
@Turbo87 Turbo87 merged commit 1579a7c into rust-lang:main Apr 9, 2025
10 checks passed
@Turbo87 Turbo87 deleted the persist-credentials branch April 9, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant