Add authorization logging across requests #12255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
approved these changes
Nov 3, 2025
Turbo87
added
the
C-internal 🔧
Contributor
Author
|
Applied your naming change, works for me. I don't really care at all, so whatever makes the most sense from your perspective. |
... for cross-checking usage of compromised keys. Specifically, adds a `custom_metadata.auth_type` value, specifying the authentication type used for actions. Additionally, adds `http.request.headers.hashed_authorization` and `http.request.headers.hashed_cookie` for logging SHA256 hashed copies of the authorization and/or cookie headers used in the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds:
Using a masked version of the authorization or cookie headers across the logs, we can specifically look for cases of tokens used across requests. This can let us detect cases such as: someone attempting tokens/cookies across multiple users, a token used across various crates, or cookie theft across users.
This came up when responding to the recent phishing incidents, where I wanted to quickly investigate, via logs, actions conducted across users and crates with specific tokens, or correlate past vs. future actions of a given user matching on token/cookie and not specifically just IP/user.