Skip to content

trustpub/tests: Nest GitHub tests under Trusted Publishing module #12316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
+525 −493
Merged

trustpub/tests: Nest GitHub tests under Trusted Publishing module #12316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
158 changes: 80 additions & 78 deletions e2e/routes/crate/settings.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,87 +59,89 @@ test.describe('Route | crate.settings', { tag: '@routes' }, () => {
});

test.describe('Trusted Publishing', () => {
test('happy path', async ({ msw, page, percy }) => {
const { crate } = await prepare(msw);

// Create two GitHub configs for the crate
msw.db.trustpubGithubConfig.create({
crate,
repository_owner: 'rust-lang',
repository_name: 'crates.io',
workflow_filename: 'ci.yml',
test.describe('GitHub', () => {
test('happy path', async ({ msw, page, percy }) => {
const { crate } = await prepare(msw);

// Create two GitHub configs for the crate
msw.db.trustpubGithubConfig.create({
crate,
repository_owner: 'rust-lang',
repository_name: 'crates.io',
workflow_filename: 'ci.yml',
});

msw.db.trustpubGithubConfig.create({
crate,
repository_owner: 'johndoe',
repository_name: 'crates.io',
workflow_filename: 'release.yml',
environment: 'release',
});

await page.goto('/crates/foo/settings');
await expect(page).toHaveURL('/crates/foo/settings');

await expect(page.locator('[data-test-trusted-publishing]')).toBeVisible();
await expect(page.locator('[data-test-add-trusted-publisher-button]')).toBeVisible();
await expect(page.locator('[data-test-github-config]')).toHaveCount(2);
await expect(page.locator('[data-test-github-config="1"] td:nth-child(1)')).toHaveText('GitHub');
let details = page.locator('[data-test-github-config="1"] td:nth-child(2)');
await expect(details).toContainText('Repository: rust-lang/crates.io');
await expect(details).toContainText('Workflow: ci.yml');
await expect(details).not.toContainText('Environment');
await expect(page.locator('[data-test-github-config="1"] [data-test-remove-config-button]')).toBeVisible();
await expect(page.locator('[data-test-github-config="2"] td:nth-child(1)')).toHaveText('GitHub');
details = page.locator('[data-test-github-config="2"] td:nth-child(2)');
await expect(details).toContainText('Repository: johndoe/crates.io');
await expect(details).toContainText('Workflow: release.yml');
await expect(details).toContainText('Environment: release');
await expect(page.locator('[data-test-github-config="2"] [data-test-remove-config-button]')).toBeVisible();
await expect(page.locator('[data-test-no-config]')).not.toBeVisible();

await percy.snapshot();

// Click the remove button
await page.click('[data-test-github-config="2"] [data-test-remove-config-button]');

// Check that the config is no longer displayed
await expect(page.locator('[data-test-github-config]')).toHaveCount(1);
details = page.locator('[data-test-github-config="1"] td:nth-child(2)');
await expect(details).toContainText('Repository: rust-lang/crates.io');
await expect(page.locator('[data-test-notification-message]')).toHaveText(
'Trusted Publishing configuration removed successfully',
);
});

msw.db.trustpubGithubConfig.create({
crate,
repository_owner: 'johndoe',
repository_name: 'crates.io',
workflow_filename: 'release.yml',
environment: 'release',
test('deletion failure', async ({ msw, page, percy }) => {
let { crate } = await prepare(msw);

// Create a GitHub config for the crate
let config = msw.db.trustpubGithubConfig.create({
crate,
repository_owner: 'rust-lang',
repository_name: 'crates.io',
workflow_filename: 'ci.yml',
environment: 'release',
});

// Mock the server to return an error when trying to delete the config
await msw.worker.use(
http.delete(`/api/v1/trusted_publishing/github_configs/${config.id}`, () => {
return HttpResponse.json({ errors: [{ detail: 'Server error' }] }, { status: 500 });
}),
);

await page.goto(`/crates/${crate.name}/settings`);
await expect(page).toHaveURL(`/crates/${crate.name}/settings`);
await expect(page.locator('[data-test-github-config]')).toHaveCount(1);

await page.click('[data-test-remove-config-button]');
await expect(page.locator('[data-test-github-config]')).toHaveCount(1);
await expect(page.locator('[data-test-notification-message]')).toHaveText(
'Failed to remove Trusted Publishing configuration: Server error',
);
});

await page.goto('/crates/foo/settings');
await expect(page).toHaveURL('/crates/foo/settings');

await expect(page.locator('[data-test-trusted-publishing]')).toBeVisible();
await expect(page.locator('[data-test-add-trusted-publisher-button]')).toBeVisible();
await expect(page.locator('[data-test-github-config]')).toHaveCount(2);
await expect(page.locator('[data-test-github-config="1"] td:nth-child(1)')).toHaveText('GitHub');
let details = page.locator('[data-test-github-config="1"] td:nth-child(2)');
await expect(details).toContainText('Repository: rust-lang/crates.io');
await expect(details).toContainText('Workflow: ci.yml');
await expect(details).not.toContainText('Environment');
await expect(page.locator('[data-test-github-config="1"] [data-test-remove-config-button]')).toBeVisible();
await expect(page.locator('[data-test-github-config="2"] td:nth-child(1)')).toHaveText('GitHub');
details = page.locator('[data-test-github-config="2"] td:nth-child(2)');
await expect(details).toContainText('Repository: johndoe/crates.io');
await expect(details).toContainText('Workflow: release.yml');
await expect(details).toContainText('Environment: release');
await expect(page.locator('[data-test-github-config="2"] [data-test-remove-config-button]')).toBeVisible();
await expect(page.locator('[data-test-no-config]')).not.toBeVisible();

await percy.snapshot();

// Click the remove button
await page.click('[data-test-github-config="2"] [data-test-remove-config-button]');

// Check that the config is no longer displayed
await expect(page.locator('[data-test-github-config]')).toHaveCount(1);
details = page.locator('[data-test-github-config="1"] td:nth-child(2)');
await expect(details).toContainText('Repository: rust-lang/crates.io');
await expect(page.locator('[data-test-notification-message]')).toHaveText(
'Trusted Publishing configuration removed successfully',
);
});

test('deletion failure', async ({ msw, page, percy }) => {
let { crate } = await prepare(msw);

// Create a GitHub config for the crate
let config = msw.db.trustpubGithubConfig.create({
crate,
repository_owner: 'rust-lang',
repository_name: 'crates.io',
workflow_filename: 'ci.yml',
environment: 'release',
});

// Mock the server to return an error when trying to delete the config
await msw.worker.use(
http.delete(`/api/v1/trusted_publishing/github_configs/${config.id}`, () => {
return HttpResponse.json({ errors: [{ detail: 'Server error' }] }, { status: 500 });
}),
);

await page.goto(`/crates/${crate.name}/settings`);
await expect(page).toHaveURL(`/crates/${crate.name}/settings`);
await expect(page.locator('[data-test-github-config]')).toHaveCount(1);

await page.click('[data-test-remove-config-button]');
await expect(page.locator('[data-test-github-config]')).toHaveCount(1);
await expect(page.locator('[data-test-notification-message]')).toHaveText(
'Failed to remove Trusted Publishing configuration: Server error',
);
});
});
});
Loading
Loading