trustpub: Implement user interface for GitLab support #12335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
16 tasks
LawnGnome
approved these changes
Nov 14, 2025
Contributor
LawnGnome
left a comment
LawnGnome
left a comment
There was a problem hiding this comment.
One messaging question; otherwise LGTM.
|
|
||
| <div class='note'> | ||
| crates.io currently only supports GitHub, but we are planning to support other platforms in the future. | ||
| Select the CI/CD platform where your publishing workflow is configured. |
Contributor
There was a problem hiding this comment.
I don't know if we want to continue to hint that we may support other platforms in the future here. I'm fine with this as it is, but just flagging that we're removing that from here.
Member
Author
There was a problem hiding this comment.
while supporting more platforms would be good, I don't think I can justify spending more time on adding additional ones, so that implementation would have to be done by the community.
since the previous statement said "planning to support other platforms in the future" I think it's probably fine to remove that part now that we do support an additional platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the majority of the frontend work for supporting GitLab in our Trusted Publishing flows. Specifically, it adjusts the crate settings section to list both GitHub and GitLab configurations, it allows crate owners to delete GitLab configurations, and it allows them to create new configurations for GitLab too.
Related