Implement trustpub_only user interface
#12390
Merged
+743
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
eth3lbert
approved these changes
Nov 25, 2025
Contributor
eth3lbert
left a comment
eth3lbert
left a comment
There was a problem hiding this comment.
I've looked through the test cases, and they look correct to me 👍
It looks like you might be missing the e2e tests. 😉
Member
Author
aaaaargh... again and again... how do I always forget this? 🙈 😅 |
This adds a `setTrustpubOnlyTask` to enable/disable the trusted publishing restriction via the PATCH `/api/v1/crates/{name}` endpoint.
The checkbox is now only visible when: - There are GitHub or GitLab trustpub configs, OR - The `trustpub_only` flag is currently enabled When the user disables the checkbox with no configs present, the checkbox stays visible for the duration of that page visit. On the next visit, it will be hidden.
…hing Shows a warning alert above the trusted publishing section when `trustpub_only` is enabled but no trusted publisher configs exist. The warning text: "Trusted publishing is required but no publishers are configured. Publishing to this crate is currently blocked."
…nner Port the QUnit tests to Playwright for the trustpub_only feature: - Warning banner visibility tests (5 tests) - Checkbox visibility and interaction tests (8 tests)
Turbo87
force-pushed
the
trustpub-only-ui
branch
from
6188fe2 to
001f165
Compare
Member
Author
fixed now. thanks again for the reminder :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the user interface seen above, to enable/disable the
trustpub_onlyflag for crates.The checkbox is only shown if a crate a) has trusted publishers configured or b) the flag is currently enabled. If the checkbox is unchecked when the crate has no more trusted publishers configured, it will stay visible until leaving the page.
The warning is shown whenever the crate has no trusted publishers configured and the flag is currently enabled.
Resolves #12361
Related
trustpub_onlyflag #12365trustpub_onlysupport #12382