Clippy cleanups #1735
Merged
Clippy cleanups #1735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will explicitly opt-in to clippy lints when using RLS.
Member
Author
|
And of course I was forgetting to use Since the renamed lint is only used in tests, I've added a hack that can be removed after the next stable release. |
Contributor
|
Do you need callgrind.out.11995 and stats.txt? |
jtgeibel
force-pushed
the
clippy-cleanups
branch
from
9c009c6 to
ffe2ff6
Compare
Member
Author
Good catch, I've removed those files. |
Contributor
|
Thanks. Looks good to me. |
Member
Author
|
@bors r+ |
Contributor
|
📌 Commit ffe2ff6 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
May 2, 2019
Clippy cleanups This series first addresses a warning now produced on nightly. Then `clippy::all` and `rust_2018_idioms` are explicitly denied for all lib, bin, and test artifacts. By denying `clippy::all`, the RLS will automatically show clippy warnings in an IDE. This only affects the RLS and `cargo clippy --all-targets` should still used in a command line workflow.
Contributor
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series first addresses a warning now produced on nightly. Then
clippy::allandrust_2018_idiomsare explicitly denied for all lib, bin, and test artifacts.By denying
clippy::all, the RLS will automatically show clippy warnings in an IDE. This only affects the RLS andcargo clippy --all-targetsshould still used in a command line workflow.