tracing: Disable colored log output on Heroku #7505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having ANSI escape sequences sprinkled across the log lines helps the readability on Papertrail, but Datadog does not support them and displays them as their regular characters which makes the logs hard to read and parse. This commit disables the color support when run on Heroku to address that issue. This might also cause a small decrease in our log volume due to the escape characters no longer counting against it.
Turbo87
added
C-internal 🔧
Turbo87
added a commit
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having ANSI escape sequences sprinkled across the log lines helps the readability on Papertrail, but Datadog does not support them and displays them as their regular characters which makes the logs hard to read and parse. This commit disables the color support when run on Heroku to address that issue.
This might also cause a small decrease in our log volume due to the escape characters no longer counting against it.