Skip to content

Add debug assert to crates-admin cli #7521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Add debug assert to crates-admin cli #7521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/bin/crates-admin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,9 @@ fn main() -> anyhow::Result<()> {
Command::EnqueueJob(command) => enqueue_job::run(command),
}
}

#[test]
fn verify_cli() {
use clap::CommandFactory;
Command::command().debug_assert();
Copy link
Member

@Turbo87 Turbo87 Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was curious what debug_assert() is doing. It looks like it runs all of https://docs.rs/clap_builder/4.4.8/src/clap_builder/builder/debug_asserts.rs.html, but only when debug_assertions is enabled, which should be the case when running the test suite. In other words, debug_assert() apparently enables some additional checks that won't even be caught when running the binary from a release build.

tl;dr LGTM 👍

}