styles: Fix button text color when hovering #9306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buttons were not meant to get a green text color when the cursor hovers over them...
Contributor
|
If we could get something like this as the output, I don't think we'd need the a.button:hover {
color: var(--text-color);
}Unfortunately, this runs into sass/sass#1425. Maybe |
Member
Author
|
Might work, but the button class can also be applied to real buttons, not just anchor tags 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buttons were not meant to get a green text color when the cursor hovers over them...
There might be a better fix for it, but I'm not seeing it right now. Feel free to comment if you know how to improve this 😉