Skip to content

admin/delete_crate: Reduce spawn_blocking() usage #9617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2024
Merged

admin/delete_crate: Reduce spawn_blocking() usage #9617

merged 3 commits into from
Oct 10, 2024

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 10, 2024 •
edited
Loading

similar to #9598

@Turbo87 Turbo87 changed the title admin/delete_version: Reduce spawn_blocking() usage admin/delete_crate: Reduce spawn_blocking() usage Oct 10, 2024
@Turbo87 Turbo87 marked this pull request as ready for review October 10, 2024 12:28
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Oct 10, 2024
@Turbo87 Turbo87 enabled auto-merge October 10, 2024 12:28
@Turbo87 Turbo87 merged commit 6dc97be into rust-lang:main Oct 10, 2024
8 checks passed
@Turbo87 Turbo87 deleted the async-delete-crate branch October 10, 2024 12:38
@codecov
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@5b08d3d). Learn more about missing BASE report.
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/admin/delete_crate.rs 0.00% 46 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9617   +/-   ##
=======================================
  Coverage        ?   88.86%           
=======================================
  Files           ?      289           
  Lines           ?    29137           
  Branches        ?        0           
=======================================
  Hits            ?    25892           
  Misses          ?     3245           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Turbo87