-
Notifications
You must be signed in to change notification settings - Fork 681
Add release_tracks meta to pagination versions
#9624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9624 +/- ##
==========================================
- Coverage 88.88% 88.79% -0.09%
==========================================
Files 289 288 -1
Lines 29130 29666 +536
==========================================
+ Hits 25892 26342 +450
- Misses 3238 3324 +86 ☔ View full report in Codecov by Sentry. |
ad9c8e0 to
8fa191f
Compare
|
I thought a bit more about ... and then I thought some more and realized that with version deletion being a thing soon it would be possible to delete that first version 😅 I think I'm back on "do we actually need it" :D |
Totally agree! I've actually been thinking about the same thing.
The And due to the above reasoning, I think I'll change this PR to focus solely on |
8fa191f to
78e4f52
Compare
78e4f52 to
e1916a2
Compare
release_tracks meta to pagination versions
e1916a2 to
97481be
Compare
|
All feedback addressed! Thanks for the review :) |
This will add `release_tracks` information to the meta field for paginated versions. This is necessary for pagination because it only loads a portion of versions per page, while `release_tracks` may require all sorted versions to determine their values. Therefore, we also need to calculate these on the server side.
…ation, sorted by semver
…ation, sorted by date
This enables clients to specify the `include` query param to include `release_tracks` meta.
97481be to
ad747b6
Compare
|
@Turbo87 all feedback has been addressed, and I believe this is ready to be merged. Let me know if anything needs to be changed. |
Turbo87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
|
Hmm, it seems this doesn't have to be restricted to only available for paginated versions since you need to specify the include parameter anyway. I'd like to have it available for non-paginated requests as well, which could make our migration to paginated versions smoother. Any thoughts, @Turbo87 ? |
|
I don't see any reason against it at first glance 👍 |
This PR will add
release_tracksinformation to themetafield for paginated versions. This is necessary for pagination because it only loads a portion of versions per page, whilerelease_tracksmay require all sorted versions to determine their values. Therefore, we also need to calculate these on the server side.Tasks:
release_tracksincludequery param