worker: Add DEDUPLICATED flag to the BackgroundJob trait
#9627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag can be set when implementing background jobs to automatically deduplicate jobs when they are enqueued. If an unstarted job already exists in the queue the `enqueue()` fn will return `Ok(None)` instead of the job ID.
Turbo87
added
C-internal 🔧
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9627 +/- ##
==========================================
+ Coverage 88.84% 88.88% +0.03%
==========================================
Files 289 289
Lines 29146 29232 +86
==========================================
+ Hits 25895 25982 +87
+ Misses 3251 3250 -1 ☔ View full report in Codecov by Sentry. |
LawnGnome
approved these changes
Oct 11, 2024
Contributor
LawnGnome
left a comment
LawnGnome
left a comment
There was a problem hiding this comment.
Took a few minutes where you could hear the gears grinding in my head to suss out the deduplicated query, but now my brain has kicked in, LGTM. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag can be set when implementing background jobs to automatically deduplicate jobs when they are enqueued. If an unstarted job already exists in the queue the
enqueue()fn will returnOk(None)instead of the job ID.This should allow us to get rid of
enqueue_sync_to_index()as a special case and make the same functionality available to other jobs as well.