Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 16, 2024

The enqueue-job admin tool has been silently failing on our staging environment since #9632 was merged. This PR fixes it by reusing our establish_async_connection() fn, which sets up the TLS configuration correctly.

It is a bit unforunate that this wasn't caught earlier though. We could potentially look into using TLS for the database connection on CI, but we'd also need to write tests for all of the admin tools (which we should do anyway...).

It is also a bit surprising that the Heroku Scheduler, which regularly uses this admin tool to enqueue regular tasks, didn't report any warnings about the tool crashing all the time, but I guess there is not much we can do on that front :-/

@Turbo87 Turbo87 added C-bug 🐞 Category: unintended, undesired behavior A-backend ⚙️ labels Oct 16, 2024
@codecov
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.71%. Comparing base (5673bdd) to head (cc93677).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/db.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9674   +/-   ##
=======================================
  Coverage   88.71%   88.71%           
=======================================
  Files         287      287           
  Lines       29339    29339           
=======================================
  Hits        26028    26028           
  Misses       3311     3311           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit 043e991 into rust-lang:main Oct 16, 2024
10 checks passed
@Turbo87 Turbo87 deleted the fix-async-conn branch October 16, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-bug 🐞 Category: unintended, undesired behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant