Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 21, 2024

The db() function with its closure comes from a time where there was only a single database connection available for each test. This restriction had been lifted quite a while ago, so this is no longer needed and we can just return the connection directly from the function instead.

Review in "hide whitespace changes" mode recommended... 😅

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Oct 21, 2024
@codecov
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (5f392c3) to head (dbae8d9).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9718      +/-   ##
==========================================
- Coverage   88.91%   88.86%   -0.05%     
==========================================
  Files         288      288              
  Lines       29624    29501     -123     
==========================================
- Hits        26340    26217     -123     
  Misses       3284     3284              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit d90ce45 into rust-lang:main Oct 22, 2024
10 checks passed
@Turbo87 Turbo87 deleted the db-conn branch October 22, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant