Skip to content

Conversation

@Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 13, 2024

Only the initial repository cloning and file listing operations are synchronous, but the rest of the code can live outside of spawn_blocking() these days.

repo.head_oid() is arguably also synchronous, but it is a fast enough operation to not matter too much for an admin tool :)

@Turbo87 Turbo87 requested a review from eth3lbert November 13, 2024 11:57
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 13, 2024
@codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 89.07%. Comparing base (2b82553) to head (9c44de5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/bin/crates-admin/upload_index.rs 0.00% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9919      +/-   ##
==========================================
- Coverage   89.08%   89.07%   -0.02%     
==========================================
  Files         290      290              
  Lines       30086    30088       +2     
==========================================
- Hits        26803    26801       -2     
- Misses       3283     3287       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eth3lbert eth3lbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me!

@Turbo87 Turbo87 merged commit 384f18b into rust-lang:main Nov 13, 2024
10 checks passed
@Turbo87 Turbo87 deleted the async-upload-index branch November 13, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants